Re: [PATCH] drm/v3d: make v3d_debugfs_init return 0

On Tue, Feb 18, 2020 at 9:28 AM Wambui Karuga wambui.karugax@gmail.com wrote:

As drm_debugfs_create_files should return void, remove its use as the return value of v3d_debugfs_init and have the function return 0 directly.

If we're going this route, then this function should be returning void, too.

Signed-off-by: Wambui Karuga wambui.karugax@gmail.com

drivers/gpu/drm/v3d/v3d_debugfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_debugfs.c b/drivers/gpu/drm/v3d/v3d_debugfs.c index 9e953ce64ef7..57dded6a3957 100644 --- a/drivers/gpu/drm/v3d/v3d_debugfs.c +++ b/drivers/gpu/drm/v3d/v3d_debugfs.c @@ -261,7 +261,8 @@ static const struct drm_info_list v3d_debugfs_list[] = { int v3d_debugfs_init(struct drm_minor *minor) {

•   return drm_debugfs_create_files(v3d_debugfs_list,
  

•                                   ARRAY_SIZE(v3d_debugfs_list),
  

•                                   minor->debugfs_root, minor);
  

•   drm_debugfs_create_files(v3d_debugfs_list,
  

•                            ARRAY_SIZE(v3d_debugfs_list),
  

•                            minor->debugfs_root, minor);
  

•   return 0;
  

}

2.25.0