Re: [PATCH 04/20] drm: move "struct drm_magic_entry" to drm_auth.c

On Fri, Aug 29, 2014 at 12:12:30PM +0200, David Herrmann wrote:

In drm_release(), we currently call drm_remove_magic() if the drm_file has a drm-magic attached. Therefore, once drm_master_release() is called, the magic-list _must_ be empty.

By dropping the no-op cleanup, we can move "struct drm_magic_entry" to drm_auth.c and avoid exposing it to all of DRM.

Signed-off-by: David Herrmann dh.herrmann@gmail.com

drivers/gpu/drm/drm_auth.c | 6 ++++++ drivers/gpu/drm/drm_drv.c | 7 ------- include/drm/drmP.h | 6 ------ 3 files changed, 6 insertions(+), 13 deletions(-)

Reviewed-by: Thierry Reding treding@nvidia.com