On 3/3/22 21:58, Thomas Zimmermann wrote:
Don't select shadow buffering for the fbdev console explicitly. The fbdev emulation's heuristic will enable it for any framebuffer with .dirty callback.
Indeed it does. Not related to your series but looking at this patch I noticed that drivers/gpu/drm/tiny/bochs.c will be the only driver that sets .prefer_shadow_fbdev after this lands.
The driver is using GEM so I wonder if after your series this DRM driver could have a .dirty callback and the field just be dropped? Or there would still be a case where it is needed ?
Anyway, just wanted to mention in case I forget later.
Your patch looks good to me and I think it could be pushed without waiting for the other patches in the series.
Reviewed-by: Javier Martinez Canillas javierm@redhat.com