Re: [PATCH v2 2/2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

Hi Markuss,

this is looking really good, the following is just nitty gritty details I could fix while applying, we're mostly waiting for DT review now.

On Sat, Aug 7, 2021 at 3:31 PM Markuss Broks markuss.broks@gmail.com wrote:

•   /*
  

•    * Exit sleep mode and initialize display - some hammering is
  

•    * necessary.
  

•    */
  

•   mipi_dbi_command(dbi, MIPI_DCS_EXIT_SLEEP_MODE);
  

•   mipi_dbi_command(dbi, MIPI_DCS_EXIT_SLEEP_MODE);
  

Check if this hammering is really necessary on s6d27a1, on Widechips this is just a bug, what happens if you put just one of them?

•   msleep(50);
  

This should be msleep(120) on s6d27a1 (according to board-codina-mcde.c)

Yours, Linus Walleij