Re: [PATCH v3 libdrm 2/2] Add drmModeGetFB2

Hi Juston,

On Thu, 23 Jan 2020 at 00:37, Juston Li juston.li@intel.com wrote:

+drm_public void drmModeFreeFB2(drmModeFB2Ptr ptr) +{

•   if (!ptr)
  

•           return;
  

•   /* we might add more frees later. */
  

•   drmFree(ptr);
  

I do not recognise this comment, and since free(NULL) is defined to be safe, this entire function can be defined as drmFree(ptr) without the comment or early return.

I would like this to be changed before merging. After the revision, this patch is: Signed-off-by: Daniel Stone daniels@collabora.com

Cheers, Daniel