Re: [PATCH v4] drm/ioctl: Add a ioctl to label GEM objects

Hey On viernes, 11 de octubre de 2019 19:09:52 (CEST) Daniel Stone wrote:

Hi Rohan,

On Fri, 11 Oct 2019 at 15:30, Rohan Garg rohan.garg@collabora.com wrote:

...

DRM_IOCTL_DUMB_SET_LABEL lets you label GEM objects, making it easier to debug issues in userspace applications.

I'm not sure if this was pointed out already, but dumb buffers != GEM buffers. GEM buffers _can_ be dumb, but might not be.

Could you please rename to GEM_SET_LABEL?

Daniel and I had a opportunity to talk about this in person and we agreed that HANDLE_SET_LABEL would be a more sensible name.

Cheers Rohan Garg