Re: [RFC v3 PATCH 08/16] drm/exynos: fimd: support I80 interface

Hi Sachin,

Thank you for comment.

I'll fix.

Thank you. Best regards YJ

On 04/30/2014 12:35 AM, Sachin Kamat wrote:

Hi YoungJun,

On 27 April 2014 07:20, YoungJun Cho yj44.cho@samsung.com wrote:

...

To support MIPI DSI command mode interface, FIMD should do followings:

• Sets LCD block configuration for I80 interface.
• Uses "lcd_sys" as an IRQ resource and sets relevant IRQ configuration.
• Implements trigger feature which transfers image date if there is page flip request, and implements TE handler to call trigger function.
• Sets CPU mode timings configuration.
• Sets ideal(pixel) clock is 2 times faster than the original one to generate frame done IRQ prior to the next TE signal.

<...>

...

•   reg = readl(timing_base + TRIGCON);
  

•   reg |= 1 << 0 | 1 << 1;
  

What does this signify? Can't this be OR'd directly with 3?