No, this very first warning continues (only once) :( From here (drm_crtc_vblank_on): if (atomic_read(&vblank->refcount) != 0 || drm_vblank_offdelay == 0) drm_WARN_ON(dev, drm_vblank_enable(dev, pipe));
Sorry, not sure when this warning is triggered.
But I'm still wondering why after step 3 we don't get -EINVAL from vblank_get() - after vblank_off() vblank->enabled should be false again, getting us back to the same state as after 1. Is that not happening?
Yes (sorry if it got confused), we got -EINVAL after setp 3:
In step 3, at the end of the 2nd running, we have: atomic_disable --> vblank_off [!vblank->inmodeset + refcount going 0->1 + inmodeset=1] and then in next vblank_get: -EINVAL (!vblank->enabled + refcount ends 1) as in the first step.
Melissa
-Daniel
Thanks -Sidong
> > > > > crtc->state->event = NULL; > > > } > > > > > > -- > > > 2.27.0 > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch