Re: [PATCH v3 1/2] drm: automatic legacy gamma support

On 10/12/2020 18:32, Ville Syrjälä wrote:

...

...

@@ -1053,18 +1052,9 @@ static int setcmap_atomic(struct fb_cmap *cmap, struct fb_info *info) goto out_state; }

• crtc_state = drm_atomic_get_crtc_state(state, crtc);
  

• if (IS_ERR(crtc_state)) {
  

• 	ret = PTR_ERR(crtc_state);
  

• ret = drm_crtc_gamma_ramp_set(state, crtc, gamma_lut);
  

• if (ret)
  

You're nesting an atomic commit in an atomic commit here, that will go boom. I guess ideally we'd move this into drm_client_modeset so it remembers the fbdev gamma ramp and does it all in one go.

IIRC that's pretty much what's in my branch that I mentioned earlier. Mentioning it again in case someone wants a leg up for implementing this idea ;)

Yep, I think your branch looks good, and I almost started working on it, but I don't think I have the time for it. I have to finish this by early next week, after which I don't know when I could continue with it (if ever, job change...).

Tomi