On Tue, May 21, 2019 at 01:08:28PM +0200, Thomas Zimmermann wrote:
Replacing drm_gem_vram_push_to_system() moves policy from drivers back to the memory manager. Now, unused BOs are only evicted when the space is required.
The lock/unlock-renaming patch aligns the interface with other names in DRM. No functional changes are done.
Finally, there's now a lockdep assert that ensures we don't call the GEM VRAM _locked() functions with an unlocked BO.
Patches are against a recent drm-tip and tested on mgag200 and ast HW.
Thomas Zimmermann (3): drm: Replace drm_gem_vram_push_to_system() with kunmap + unpin drm: Rename reserve/unreserve to lock/unlock in GEM VRAM helpers drm: Assert that BO is locked in drm_gem_vram_{pin,unpin}_locked()
Awesome, thanks a lot for quickly working on this. On the series:
Acked-by: Daniel Vetter daniel.vetter@ffwll.ch
But definitely get someone with more knowledge of the details to check this all again.
Aside: Do you plan to continue working on drm drivers, i.e. any need for drm-misc commit rights?
Cheers, Daniel
drivers/gpu/drm/ast/ast_fb.c | 11 ++- drivers/gpu/drm/ast/ast_mode.c | 26 ++++--- drivers/gpu/drm/drm_gem_vram_helper.c | 86 ++++++------------------ drivers/gpu/drm/drm_vram_helper_common.c | 2 - drivers/gpu/drm/mgag200/mgag200_cursor.c | 40 +++++------ drivers/gpu/drm/mgag200/mgag200_fb.c | 11 ++- drivers/gpu/drm/mgag200/mgag200_mode.c | 15 +++-- include/drm/drm_gem_vram_helper.h | 9 ++- 8 files changed, 80 insertions(+), 120 deletions(-)
-- 2.21.0