Re: [PATCH v7 03/24] drm/rockchip: dw_hdmi: rename vpll clock to reference clock

On 2/25/22 10:51, Sascha Hauer wrote:

"vpll" is a misnomer. A clock input to a device should be named after the usage in the device, not after the clock that drives it. On the rk3568 the same clock is driven by the HPLL. To fix that, this patch renames the vpll clock to ref clock. The clock name "vpll" is left for compatibility to old device trees.

Signed-off-by: Sascha Hauer s.hauer@pengutronix.de

Notes: Changes since v6: - Simplify by using devm_clk_get_optional() instead of devm_clk_get()

drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 27 +++++++++++---------- 1 file changed, 14 insertions(+), 13 deletions(-)

Looks nice now. Thank you!

Reviewed-by: Dmitry Osipenko dmitry.osipenko@collabora.com