Re: [PATCH v6 4/5] ARM: dts: da850-lcdk: add the vga-bridge node

Hi,

On 12/12/16 15:05, Bartosz Golaszewski wrote:

+&lcdc {

• status = "okay";
• pinctrl-names = "default";
• pinctrl-0 = <&lcd_pins>;
• ports {

• #address-cells = <1>;
  

• #size-cells = <0>;
  

• lcdc_out: port@1 {
  

• 	#address-cells = <1>;
  

• 	#size-cells = <0>;
  

• 	reg = <1>;
  

• 	lcdc_out_vga: endpoint {
  

• 		reg = <0>;
  

• 		remote-endpoint = <&vga_bridge_in>;
  

• 	};
  

• };
  

• };

+};

This is not correct. LCDC has just one output, so port@1 doesn't make sense. It's port@0. But with just one port, you can leave "ports" away. And you don't need the port's label for anything, if I'm not mistaken. So:

&lcdc { status = "okay"; pinctrl-names = "default"; pinctrl-0 = <&lcd_pins>;

port { lcdc_out_vga: endpoint { remote-endpoint = <&vga_bridge_in>; }; }; };

Tomi