Re: [PATCH v4] drm/amdgpu: fix multiple memory leaks in acp_hw_init

Why did you omit the patch change log at this place?

drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 34 ++++++++++++++++---------

+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c @@ -189,7 +189,7 @@ static int acp_hw_init(void *handle)

…

• struct i2s_platform_data *i2s_pdata = NULL;

…

I propose to reconsider this update suggestion once more.

@@ -393,6 +396,13 @@ static int acp_hw_init(void *handle) val &= ~ACP_SOFT_RESET__SoftResetAud_MASK; cgs_write_register(adev->acp.cgs_device, mmACP_SOFT_RESET, val); return 0;

+failure:

• kfree(i2s_pdata);
• kfree(adev->acp.acp_res);
• kfree(adev->acp.acp_cell);
• kfree(adev->acp.acp_genpd);
• return r;

}

/**

Are you going to follow a known programming guideline? https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto...

Regards, Markus