Op 17-01-17 om 02:12 schreef Laurent Pinchart:
Hi Maarten,
Thank you for the patch.
I don't think you need the "v2" at the end of the subject line.
On Monday 16 Jan 2017 10:37:43 Maarten Lankhorst wrote:
This is a straightforward conversion that converts all the users of get_existing_state in atomic core to use get_old_state or get_new_state
Changes since v1:
- Fix using the wrong state in
drm_atomic_helper_update_legacy_modeset_state.
Signed-off-by: Maarten Lankhorst maarten.lankhorst@linux.intel.com
drivers/gpu/drm/drm_atomic.c | 6 +++--- drivers/gpu/drm/drm_atomic_helper.c | 39 +++++++++++++++------------------ drivers/gpu/drm/drm_blend.c | 3 +-- 3 files changed, 22 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 7b61e0da9ace..6428e9469607 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c
[snip]
@@ -1835,7 +1832,7 @@ drm_atomic_helper_commit_planes_on_crtc(struct drm_crtc_state *old_crtc_state)
drm_for_each_plane_mask(plane, crtc->dev, plane_mask) { struct drm_plane_state *old_plane_state =
drm_atomic_get_existing_plane_state(old_state, plane);
drm_atomic_get_old_plane_state(old_state, plane);I believe this change to be correct, but given that the function is called after state swap, didn't it use the new state before this patch ?
get_existing_state returns the old state after swap.
But the call to drm_atomic_plane_disabling is confusing to me. I'm changing the function to pass old and new plane state, which should make it easier to understand.
Cheers, ~Maarten