On 08/06/2022 12:05, Krzysztof Kozlowski wrote:
On 07/06/2022 20:58, Dmitry Baryshkov wrote:
Mark obsolete GPIO properties as deprecated. They are not used by existing device trees. While we are at it, also drop them from the schema example.
Signed-off-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org
.../devicetree/bindings/display/msm/qcom,hdmi.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml b/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml index 2f485b5d1c5d..2b1cac0851ce 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml @@ -59,22 +59,27 @@ properties:
qcom,hdmi-tx-ddc-clk-gpios: maxItems: 1
deprecated: true description: HDMI DDC clock
qcom,hdmi-tx-ddc-data-gpios: maxItems: 1
deprecated: true
This is confusing. These two are not defined in the old bindings, not used by DTS, not used by Linux implementation - why did you add them?
Most probably I added them as they were referenced in the source (and in the example). I'll drop these two completely (and document removing them from the example).
description: HDMI DDC data qcom,hdmi-tx-mux-en-gpios: maxItems: 1
deprecated: true description: HDMI mux enable pin
qcom,hdmi-tx-mux-sel-gpios: maxItems: 1
deprecated: true description: HDMI mux select pin
qcom,hdmi-tx-mux-lpm-gpios: maxItems: 1
deprecated: true description: HDMI mux lpm pin
'#sound-dai-cells':
@@ -171,8 +176,6 @@ examples: <&clk 61>, <&clk 72>, <&clk 98>;
qcom,hdmi-tx-ddc-clk-gpios = <&msmgpio 70 0>;qcom,hdmi-tx-ddc-data-gpios = <&msmgpio 71 0>; hpd-gpios = <&msmgpio 72 0>; core-vdda-supply = <&pm8921_hdmi_mvs>; hdmi-mux-supply = <&ext_3p3v>;