Den 04.09.2019 16.39, skrev Daniel Vetter:
- it's what we recommend in our docs:
https://dri.freedesktop.org/docs/drm/gpu/drm-uapi.html#recommended-ioctl-ret...
- it's the overwhelmingly used error code for "operation not supported", at least in drm core (slightly less so in drivers):
$ git grep EOPNOTSUP -- drivers/gpu/drm/*c | wc -l 83 $ git grep ENOTSUP -- drivers/gpu/drm/*c | wc -l 5
- include/linux/errno.h makes it fairly clear that these are for nfsv3 (plus they also have error codes above 512, which is the block with some special behaviour ...)
/* Defined for the NFSv3 protocol */
If the above isn't reflecting current practice, then I guess we should at least update the docs.
Cc: José Roberto de Souza jose.souza@intel.com Cc: Maarten Lankhorst maarten.lankhorst@linux.intel.com Cc: Maxime Ripard mripard@kernel.org Cc: Sean Paul sean@poorly.run Cc: Alex Deucher alexander.deucher@amd.com Cc: Andres Rodriguez andresx7@gmail.com Cc: Noralf Trønnes noralf@tronnes.org Signed-off-by: Daniel Vetter daniel.vetter@intel.com
drivers/gpu/drm/drm_edid.c | 6 +++--- drivers/gpu/drm/drm_mipi_dbi.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-)
Acked-by: Noralf Trønnes noralf@tronnes.org
Ben Hutchings made this comment[1] in a thread about use of ENOTSUPP in drivers:
glibc's strerror() returns these strings for ENOTSUPP and EOPNOTSUPP respectively:
"Unknown error 524" "Operation not supported"
So at least for errors returned to userspace EOPNOTSUPP makes sense.
Noralf.