13 Aug
2021
13 Aug
'21
4:08 p.m.
On Fri, Aug 13, 2021 at 06:51:05PM +0300, Andy Shevchenko wrote:
On Fri, Aug 13, 2021 at 09:17:11AM -0600, Jim Cromie wrote:
+int param_set_dyndbg(const char *instr, const struct kernel_param *kp) +{
- unsigned long inbits;
- int rc, i, chgct = 0, totct = 0;
- char query[OUR_QUERY_SIZE];
- struct dyndbg_bitdesc *bitmap = (struct dyndbg_bitdesc *) kp->data;
So you need space after ')' ?
More importantly, if ->data is of type 'void *', it is bad style to cast the pointer at all. I can't tell what type 'data' has; if it is added to kernel_param as part of this series, I wasn't cc'd on the patch that did that.