Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

On Sun, Aug 23, 2015 at 06:23:14PM -0500, Rob Herring wrote:

On Wed, Aug 19, 2015 at 9:50 AM, Yakir Yang ykk@rock-chips.com wrote:

[...]

...

•   -analogix,link-rate:
  

•           max link rate supported by the eDP controller.
  

•                   LINK_RATE_1_62GBPS = 0x6, LINK_RATE_2_70GBPS = 0x0A,
  

•                   LINK_RATE_5_40GBPS = 0x14
  

Same here. I'd rather see something like "link-rate-mbps" and use the actual rate.

There is no need whatsoever to hard-code this in DT. (e)DP provides the means to detect what rate the link supports and the specification provides guidance on how to select an appropriate one.

...

•   -analogix,lane-count:
  

•           max number of lanes supported by the eDP contoller.
  

•                   LANE_COUNT1 = 1, LANE_COUNT2 = 2, LANE_COUNT4 = 4
  

And drop the vendor prefix here.

Same as for the link rate.

Thierry