6 Mar
2019
6 Mar
'19
6 a.m.
Hi Laurent.
- @DRM_BUS_FLAG_DE_LOW: The Data Enable signal is active low
- @DRM_BUS_FLAG_DE_HIGH: The Data Enable signal is active high
- @DRM_BUS_FLAG_PIXDATA_POSEDGE: Legacy value, do not use
- @DRM_BUS_FLAG_PIXDATA_NEGEDGE: Legacy value, do not use
Could you extend the comment to expalin what there replacements are? Otherwise we leave it to someone with less understanding of the subject to find out. There are 30+ cases we need to fix and we better do it right.
This patch will be merged as part of a series that replaces all the existing users of the legacy values. I'm leaving them here just in case another patch using them would be merged at the same time, and will then submit a patch to remove them.
It would also be nice to have the legacy values grouped so they are easier to ignore.
Can I keep this patch as-is given that I will remove the legacy values soon ?
Thats much better so we gid of some legacy. With this you can add my: Reviewed-by: Sam Ravnborg sam@ravnborg.org