20 May
2015
20 May
'15
2:18 p.m.
On Wed, May 20, 2015 at 9:01 PM, Arnd Bergmann arnd@arndb.de wrote:
On Wednesday 20 May 2015 13:32:33 Thierry Reding wrote:
Since these are all static functions, perhaps an "if (IS_ENABLED(...))" would work here? That way you'd get compile coverage of the code in all cases.
I had the same thought at first.
But perhaps that doesn't work for IOMMU. I have a vague memory of running across something like this before and IOMMU has this quirk of defining struct iommu_ops as empty if IOMMU_API is deselected so you'll probably get compiler errors unless you actually preprocess the code out.
Exactly.
That's precisely the issue here, so not covering this code is exactly what we want if !CONFIG_IOMMU.