Re: [PATCH v4 3/6] drm: Add driver for Solomon SSD130x OLED displays

Hello Geert,

On 2/11/22 13:23, Geert Uytterhoeven wrote:

[snip]

...

...

...

• if (IS_ERR(bl)) {

...

•        ret = PTR_ERR(bl);
  

•        dev_err_probe(dev, ret, "Unable to register backlight device\n");
  

•        return ERR_PTR(ret);
  

          dev_err_probe(dev, PTR_ERR(bl), "Unable to register backlight device\n");
          return bl;

?

No, because this function's return value is a struct ssd130x_device pointer, not a struct backlight_device pointer.

Hence

return ERR_PTR(dev_err_probe(dev, PTR_ERR(bl),
                             "Unable to register backlight device\n"));

?

Thanks, that would work.

Best regards,