Hello Eric,
This is an attempt at fixing support for negative X/Y positioning of various FB formats. I kept you as the author since I started from your initial work and fixed a few things + split the changes in several commits. Let me know if that's a problem, and I change the author.
This series has been tested with a modified modetest (support for this modifier has been added).
Note that I plan to test/debug support for negative X/Y positioning of SANDXX planes.
Regards,
Boris
Eric Anholt (5): drm/vc4: Fix TILE_Y_OFFSET definitions drm/vc4: Define missing PICTH0_SINK_PIX field drm/vc4: Use drm_atomic_helper_check_plane_state() to simplify the logic drm/vc4: Move ->offsets[] adjustment out of setup_clipping_and_scaling() drm/vc4: Fix negative X/Y positioning of planes using T_TILES modifier
drivers/gpu/drm/vc4/vc4_drv.h | 9 -- drivers/gpu/drm/vc4/vc4_plane.c | 272 ++++++++++++++++++++++++---------------- drivers/gpu/drm/vc4/vc4_regs.h | 8 +- 3 files changed, 170 insertions(+), 119 deletions(-)