On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann arnd@kernel.org wrote:
On Wed, May 4, 2022 at 11:59 PM Linus Walleij linus.walleij@linaro.org wrote:
Thus drop one ! in front of the expression, just !SND_SOC_DAPM_EVENT_ON(event)
Ok, done. But I still leave the extra 'invert=1' in hs_jack_pin[], right?
/* Headphones jack detection DAPM pin */ static struct snd_soc_jack_pin hs_jack_pin[] = { { .pin = "Headphone Jack", .mask = SND_JACK_HEADPHONE, }, { .pin = "Speaker", /* disable speaker when hp jack is inserted */ .mask = SND_JACK_HEADPHONE, .invert = 1, },
Hm some ASoC thingie. No idea what that is, but I suppose another place where a subsystem for legacy reasons try to do the gpiolib inversion on it's own accord. That one isn't flagged as active low in the descriptor so it's fine I guess.
Possible this should be fixed in ASoC to rely on gpiolib but we can't fix the entire world.
Yours, Linus Walleij