Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling

On 09-11-20, 08:19, Dmitry Osipenko wrote:

Thanks, I made it in a different way by simply adding helpers to the pm_opp.h which use devm_add_action_or_reset(). This doesn't require to add new kernel symbols.

I will prefer to add it in core.c itself, and yes devm_add_action_or_reset() looks better. But I am still not sure for which helpers do we need the devm_*() variants, as this is only useful for non-CPU devices. But if we have users that we can add right now, why not.

static inline int devm_pm_opp_of_add_table(struct device *dev) { int err;

err = dev_pm_opp_of_add_table(dev); if (err) return err;

err = devm_add_action_or_reset(dev, (void*)dev_pm_opp_remove_table, dev); if (err) return err;

return 0; }