Re: [PATCH] drm: Added orientation quirk for OneGX1 Pro

Hi,

On 1/20/21 9:56 PM, Jared Baldridge wrote:

The OneGX1 Pro has a fairly unique combination of generic strings, but we additionally match on the BIOS date just to be safe.

Signed-off-by: Jared Baldridge jrb@expunge.us

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede hdegoede@redhat.com

I will push this to drm-misc-next right away.

Regards,

Hans

---

drivers/gpu/drm/drm_panel_orientation_quirks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 58f5dc2f6dd5..f6bdec7fa925 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -84,6 +84,13 @@ static const struct drm_dmi_panel_orientation_data itworks_tw891 = { .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, };

+static const struct drm_dmi_panel_orientation_data onegx1_pro = {

•   .width = 1200,
  

•   .height = 1920,
  

•   .bios_dates = (const char * const []){ "12/17/2020", NULL },
  

•   .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP,
  

+};

static const struct drm_dmi_panel_orientation_data lcd720x1280_rightside_up = { .width = 720, .height = 1280, @@ -211,6 +218,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), }, .driver_data = (void *)&lcd1200x1920_rightside_up,

•   }, {    /* OneGX1 Pro */
  

•           .matches = {
  

•             DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SYSTEM_MANUFACTURER"),
  

•             DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SYSTEM_PRODUCT_NAME"),
  

•             DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Default string"),
  

•           },
  

•           .driver_data = (void *)&onegx1_pro,
    }, {    /* VIOS LTH17 */
            .matches = {
              DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),