On Fri, 12 Oct 2018 at 00:18, Rob Clark robdclark@gmail.com wrote:
From: Rob Clark robclark@freedesktop.org
drmMalloc() is already calloc()
Signed-off-by: Rob Clark robclark@freedesktop.org
For the patch Reviewed-by: Emil Velikov emil.velikov@collabora.com
Small micro-optimization that I noticed while doing some perf work.. I should probably look at promoting amdgpu's handle_table to core libdrm and replacing a couple of libdrm_freedreno's xf86drmHash tables over to that. There is still at least one hashtable (in some libdrm_freedreno patches I'm working on finalizing) where handle_table would not be appropriate (ie. key is a ptr).. but the answer there might be importing a better hashtable implementation into libdrm.
Please remember to nuke some of the existing hash implementations, if you want to add new one. The more (nuked) the better.
Related note, once I land a libdrm_freedreno patchset (hopefully tomorrow or over the weekend), I'll have interest in making a libdrm release so I can start landing mesa patches that will depend on that.. so if anyone else wants me to wait a few days so they can push something before the next libdrm release, please let me know.
There's nothing urgent on my end.
Thanks Emil