Hi Sam,
Em Wed, 19 Aug 2020 22:48:00 +0200 Sam Ravnborg sam@ravnborg.org escreveu:
Hi Mauro.
It seems my review comments failed to reach dri-devel - likely due to the size of the mail.
Probably. It reached here properly.
Link: https://lore.kernel.org/linux-devicetree/20200819173558.GA3733@ravnborg.org/
I my review feedback I refer to checkpatch a few time. For drivers/gpu/ we have some nice tooling support. One thing our tooling does for us is running checkpatch every time we apply a patch.
checkpatch -q --emacs --strict --show-typesSo we expect patches to be more or less checkpatch --strict clean.
"more or less" - as common sense also plays a role. And sometimes checkpatch is just wrong.
Just in case you wondered why checkpatch --strict was requested.
We also use checkpatch --strict for media as a reference, ignoring the things that would make things worse during review :-)
I'll run checkpatch here and ensure that the coding style issues will be properly addressed.
Thanks, Mauro