Re: [Nouveau] [PATCH 2/5] drm/nouveau: Grab RPM ref while probing outputs

On Mon, Jul 16, 2018 at 07:59:26PM -0400, Lyude Paul wrote:

--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -2012,10 +2012,18 @@ nv50_disp_atomic_state_alloc(struct drm_device *dev) return &atom->state; }

+static void +nouveau_output_poll_changed(struct drm_device *dev) +{

• pm_runtime_get_sync(dev->dev);
• drm_fb_helper_hotplug_event(dev->fb_helper);
• pm_runtime_put_autosuspend(dev->dev);

+}

static const struct drm_mode_config_funcs nv50_disp_func = { .fb_create = nouveau_user_framebuffer_create,

• .output_poll_changed = drm_fb_helper_output_poll_changed,

• .output_poll_changed = nouveau_output_poll_changed,

It might make sense to provide a generic DRM helper for this. Same for patch 3 in this series.

Thanks,

Lukas