3 Jun
2020
3 Jun
'20
2:21 a.m.
On Tue, Jun 02, 2020 at 01:10:34PM +0200, Markus Elfring wrote:
The original patch was basically fine.
I propose to reconsider the interpretation of the software situation once more.
- Should the allocated clock object be kept usable even after a successful return from this function?
Heh. You're right. The patch is freeing "clk" on the success path so that doesn't work.
Ben has explained this problem: https://lore.kernel.org/patchwork/patch/1249592/ Since the caller will check "pclk" on failure, we don't need to free "clk" in gm20b_clk_new() and I think this patch is no longer needed.
Regards, Dinghao