On Mon, May 11, 2020 at 04:50:14PM -0500, Rob Herring wrote:
On Fri, Apr 24, 2020 at 05:35:11PM +0200, Maxime Ripard wrote:
The HDMI controllers found in the BCM2711 SoC need some adjustments to the bindings, especially since the registers have been shuffled around in more register ranges.
Cc: Rob Herring robh+dt@kernel.org Cc: devicetree@vger.kernel.org Signed-off-by: Maxime Ripard maxime@cerno.tech
Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 109 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml new file mode 100644 index 000000000000..6091fe3d315b --- /dev/null +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml @@ -0,0 +1,109 @@ +# SPDX-License-Identifier: GPL-2.0
Dual license
+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Broadcom BCM2711 HDMI Controller Device Tree Bindings
+maintainers:
- Eric Anholt eric@anholt.net
+properties:
- compatible:
- enum:
- brcm,bcm2711-hdmi0- brcm,bcm2711-hdmi1- reg:
- items:
- description: HDMI controller register range- description: DVP register range- description: HDMI PHY register range- description: Rate Manager register range- description: Packet RAM register range- description: Metadata RAM register range- description: CSC register range- description: CEC register range- description: HD register range- reg-names:
- items:
- const: hdmi- const: dvp- const: phy- const: rm- const: packet- const: metadata- const: csc- const: cec- const: hd- clocks:
- description: The HDMI state machine clock
- clock-names:
- const: hdmi
- ddc:
- allOf:
- $ref: /schemas/types.yaml#/definitions/phandle- description: >
Phandle of the I2C controller used for DDC EDID probingThis belongs in a connector node. (ddc-i2c-bus)
- hpd-gpios:
- description: >
The GPIO pin for the HDMI hotplug detect (if it doesn't appearas an interrupt/status bit in the HDMI controller itself)This belongs in a connector node.
If we were to create a new binding, sure, but we're merely reusing the old binding that is already there. The only reason it's in a separate file is because you said it would be clearer in a separate file.
Maxime