Re: [PATCH] drm/mediatek: mtk_hdmi: Remove debug messages for function calls

Hi, Enric:

Chun-Kuang Hu chunkuang.hu@kernel.org 於 2020年5月19日 週二 下午11:13寫道：

Hi, Enric:

Enric Balletbo i Serra enric.balletbo@collabora.com 於 2020年5月19日 週二 下午5:41寫道：

...

Equivalent information can be nowadays obtained using function tracer

Reviewed-by: Chun-Kuang Hu chunkuang.hu@kernel.org

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?...

Regards, Chun-Kuang.

...

Signed-off-by: Enric Balletbo i Serra enric.balletbo@collabora.com

drivers/gpu/drm/mediatek/mtk_hdmi.c | 12 +----------- drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 4 ---- 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index b0555a7cb3b4..172d67294435 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1634,8 +1634,6 @@ static int mtk_hdmi_audio_startup(struct device *dev, void *data) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev);

•   dev_dbg(dev, "%s\n", __func__);
  

•   mtk_hdmi_audio_enable(hdmi);
  
    return 0;
  

@@ -1645,8 +1643,6 @@ static void mtk_hdmi_audio_shutdown(struct device *dev, void *data) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev);

•   dev_dbg(dev, "%s\n", __func__);
  

•   mtk_hdmi_audio_disable(hdmi);
  

}

@@ -1655,8 +1651,6 @@ mtk_hdmi_audio_digital_mute(struct device *dev, void *data, bool enable) { struct mtk_hdmi *hdmi = dev_get_drvdata(dev);

•   dev_dbg(dev, "%s(%d)\n", __func__, enable);
  

•   if (enable)
            mtk_hdmi_hw_aud_mute(hdmi);
    else
  

@@ -1669,8 +1663,6 @@ static int mtk_hdmi_audio_get_eld(struct device *dev, void *data, uint8_t *buf, { struct mtk_hdmi *hdmi = dev_get_drvdata(dev);

•   dev_dbg(dev, "%s\n", __func__);
  

•   memcpy(buf, hdmi->conn.eld, min(sizeof(hdmi->conn.eld), len));
  
    return 0;
  

@@ -1770,7 +1762,6 @@ static int mtk_drm_hdmi_probe(struct platform_device *pdev) goto err_bridge_remove; }

•   dev_dbg(dev, "mediatek hdmi probe success\n");
    return 0;
  
  

err_bridge_remove: @@ -1793,7 +1784,7 @@ static int mtk_hdmi_suspend(struct device *dev) struct mtk_hdmi *hdmi = dev_get_drvdata(dev);

    mtk_hdmi_clk_disable_audio(hdmi);

•   dev_dbg(dev, "hdmi suspend success!\n");
  

•   return 0;
  

}

@@ -1808,7 +1799,6 @@ static int mtk_hdmi_resume(struct device *dev) return ret; }

•   dev_dbg(dev, "hdmi resume success!\n");
    return 0;
  

} #endif diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c index b55f51675205..1c3575372230 100644 --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c @@ -159,8 +159,6 @@ static int mtk_hdmi_pll_prepare(struct clk_hw *hw) { struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw);

•   dev_dbg(hdmi_phy->dev, "%s\n", __func__);
  

•   mtk_hdmi_phy_set_bits(hdmi_phy, HDMI_CON1, RG_HDMITX_PLL_AUTOK_EN);
    mtk_hdmi_phy_set_bits(hdmi_phy, HDMI_CON0, RG_HDMITX_PLL_POSDIV);
    mtk_hdmi_phy_clear_bits(hdmi_phy, HDMI_CON3, RG_HDMITX_MHLCK_EN);
  

@@ -178,8 +176,6 @@ static void mtk_hdmi_pll_unprepare(struct clk_hw *hw) { struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw);

•   dev_dbg(hdmi_phy->dev, "%s\n", __func__);
  

•   mtk_hdmi_phy_clear_bits(hdmi_phy, HDMI_CON1, RG_HDMITX_PLL_TXDIV_EN);
    mtk_hdmi_phy_clear_bits(hdmi_phy, HDMI_CON1, RG_HDMITX_PLL_BIAS_LPF_EN);
    usleep_range(100, 150);
  

-- 2.26.2