Re: [PATCH v4 0/4] drm: Provide a simple encoder

Hi Thomas.

On Fri, Feb 28, 2020 at 09:18:24AM +0100, Thomas Zimmermann wrote:

Many DRM drivers implement an encoder with an empty implementation. This patchset adds drm_simple_encoder_init(), which drivers can use instead. Except for the destroy callback, the simple encoder's implementation is empty.

The patchset also converts 4 encoder instances to use the simple-encoder helpers. But there are at least 11 other drivers which can use the helper and I think I did not examine all drivers yet.

The patchset was smoke-tested on mgag200 by running the fbdev console and Gnome on X11.

v4:

• print error messages with drm_err() (Sam)
• qxl: handle errors of drm_simple_encoder_init() (Sam)

Looked through the patches - all looked good. IMO ready to apply.

Sam