On Fri, Apr 01, 2022 at 03:19:26PM -0700, Francisco Jerez wrote:
Daniel Vetter daniel@ffwll.ch writes:
On Wed, Mar 30, 2022 at 02:53:11PM -0700, Matt Atwood wrote:
...
@@ -2718,6 +2719,9 @@ struct drm_i915_query_item { * - DRM_I915_QUERY_PERF_CONFIG_LIST * - DRM_I915_QUERY_PERF_CONFIG_DATA_FOR_UUID * - DRM_I915_QUERY_PERF_CONFIG_FOR_UUID
** When query_id == DRM_I915_QUERY_GEOMETRY_SUBSLICES must have a valid* i915_engine_class_instance struct.It would also be worth adding to the documentation that the specified engine must be a render engine instance.
*/__u32 flags; #define DRM_I915_QUERY_PERF_CONFIG_LIST 1 @@ -2776,16 +2780,20 @@ struct drm_i915_query { };
/*
Can we please include this in the kerneldoc, and also make sure that the queries are nicely all listed somewhere and link to each respective information structure?
Most of the doc for queries is there now, but the presentation and linking lacks still a lot. -Daniel
MattA is out at the moment, so I've picked this up in his absence; I sent a new series here that includes various kerneldoc updates in addition to his patch:
https://patchwork.freedesktop.org/series/102553/
Let me know if that's more along the lines of what you guys were looking for.
Matt
- Data written by the kernel with query DRM_I915_QUERY_TOPOLOGY_INFO :
- Data written by the kernel with query DRM_I915_QUERY_TOPOLOGY_INFO,
- DRM_I915_QUERY_GEOMETRY_SUBSLICE:
- data: contains the 3 pieces of information :
- the slice mask with one bit per slice telling whether a slice is
- available. The availability of slice X can be queried with the following
- formula :
- For DRM_I915_QUERY_TOPOLOGY_INFO the slice mask with one bit per slice
- telling whether a slice is available. The availability of slice X can be
- queried with the following formula :
(data[X / 8] >> (X % 8)) & 1
- For DRM_I915_QUERY_GEOMETRY_SUBSLICES Slices are equal to 1 and this field
- is not used.
- the subslice mask for each slice with one bit per subslice telling
- whether a subslice is available. Gen12 has dual-subslices, which are
- similar to two gen11 subslices. For gen12, this array represents dual-
-- 2.21.3
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch