On Mon, Aug 27, 2018 at 12:47:17PM +0530, Sharat Masetty wrote:
Call the devfreq_remove_device() API to remove the GPU devfreq instance during GPU driver cleanup.
Signed-off-by: Sharat Masetty smasetty@codeaurora.org
drivers/gpu/drm/msm/msm_gpu.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 04f9604..8d6bc0c 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -970,6 +970,8 @@ void msm_gpu_cleanup(struct msm_gpu *gpu)
WARN_ON(!list_empty(&gpu->active_list));
- devm_devfreq_remove_device(&gpu->pdev->dev, gpu->devfreq.devfreq);
Sorry, I don't think I made myself clear. We should use devm_devfreq_add_device during initialization so that we don't need to do a devfreq_remove_device during cleanup. This will still be a one line patch but in a different location.
Jordan
for (i = 0; i < ARRAY_SIZE(gpu->rb); i++) { msm_ringbuffer_destroy(gpu->rb[i]); gpu->rb[i] = NULL; -- 1.9.1