Re: [PATCH v5 13/36] PM / devfreq: tegra30: Use MC timings for building OPP table

28.08.2020 04:47, Chanwoo Choi пишет:

Hi,

...

...

Hence the NULL-checking is unnecessary.

When I first encountered the of_device_get_match_data(), I was also thinking that adding the NULL-checks is a good idea, but later on somebody pointed out to me (maybe Thierry) that it's unnecessary to do.

OK. Thanks.

...

...

...

• mc = tegra_get_memory_controller(soc_data->mc_compatible);
• if (IS_ERR(mc))

• return PTR_ERR(mc);
  

You better to add error log.

In practice we should get only -EPROBE_DEFER here ever. I'll consider adding the message in the next revision, at least just for consistency.

In order to handle -EPROBE_DEFER, recommend the using of dev_err_probe().

Hello, Chanwoo!

Thank you for the suggestion! I wasn't aware about the dev_err_probe() until recently and will use this new helper in the v6!

Thanks!