On Tue, Nov 10, 2020 at 12:54:21PM -0500, Andrey Grodzovsky wrote:
Hi, back to this after a long context switch for some higher priority stuff.
So here I was able eventually to drop all this code and this change here https://cgit.freedesktop.org/~agrodzov/linux/commit/?h=amd-staging-drm-next-... was enough for me. Seems like while device_remove_file can handle the use case where the file and the parent directory already gone, sysfs_remove_group goes down in flames in that case due to kobj->sd being unset on device removal.
A driver shouldn't ever have to remove individual sysfs groups, the driver core/bus logic should do it for them automatically.
And whenever a driver calls a sysfs_* call, that's a hint that something is not working properly.
Also, run your patch above through checkpatch.pl before submitting it :)
thanks,
greg k-h