Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes

On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote:

Add the nodes for the MSTPRI configuration and DDR2/mDDR memory controller drivers to da850.dtsi.

Signed-off-by: Bartosz Golaszewski bgolaszewski@baylibre.com

v1 -> v2:

• moved the priority controller node above the cfgchip node
• renamed added nodes to better reflect their purpose

arch/arm/boot/dts/da850.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 1bb1f6d..412eec6 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -210,6 +210,10 @@ };

};

• prictrl: priority-controller@14110 {
  

• 	compatible = "ti,da850-mstpri";
  

• 	reg = <0x14110 0x0c>;
  

I think we should add status = "disabled"; here and let boards opt in.

• };
  

  cfgchip: chip-controller@1417c { compatible = "ti,da830-cfgchip", "syscon", "simple-mfd"; reg = <0x1417c 0x14>;

@@ -451,4 +455,8 @@ 1 0 0x68000000 0x00008000>; status = "disabled"; };

• memctrl: memory-controller@b0000000 {

• compatible = "ti,da850-ddr-controller";
  

• reg = <0xb0000000 0xe8>;
  

same here. status = "disabled";

• };

};