On 30.07.2014 02:10, Jerome Glisse wrote:
On Tue, Jul 29, 2014 at 01:05:15PM -0400, Alex Deucher wrote:
On Tue, Jul 29, 2014 at 11:39 AM, Jerome Glisse j.glisse@gmail.com wrote:
On Tue, Jul 29, 2014 at 10:33:18AM -0400, Alex Deucher wrote:
Return 2 so we can be sure the kernel has the necessary changes for acceleration to work.
I highly dislike that ? Why about just using nop2 in userspace ?
How to we tell whether the version of mesa has that change or not?
You do not need to know that in kernel, all that is needed is for userspace to test 3.16 kernel as it's all that is needed to get accel working.
What if the Hawaii fixes are backported to older kernels?
So i would say enable accel on ddx now because truly if someone update its ddx then it must have updated mesa too.
There is no such guarantee.
This looks like a pretty good solution to me. Please add a check for this in the Gallium winsys code as well for the benefit of non-X apps such as Wayland compositors.