Re: [Intel-gfx] [PATCH 5/7] drm/i915: Pipe-C only configurations would not get SR

On Tue, Aug 14, 2012 at 5:34 AM, Keith Packard keithp@keithp.com wrote:

These should probably all look like

    enabled |= (1 << pipe)

so that the intent is clear...

Signed-off-by: Keith Packard keithp@keithp.com

drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 94aabca..1a84425 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -1815,7 +1815,7 @@ static void sandybridge_update_wm(struct drm_device *dev) DRM_DEBUG_KMS("FIFO watermarks For pipe C -" " plane %d, cursor: %d\n", plane_wm, cursor_wm);

•           enabled |= 3;
  

•           enabled |= 4;
    }
  

Looks like a very good catch!

Reviewed-by: Damien Lespiau damien.lespiau@intel.com