Hi Sam,
Am Freitag, dem 09.07.2021 um 20:08 +0200 schrieb Sam Ravnborg:
Hi Yunus,
On Tue, Jul 06, 2021 at 09:59:07AM +0200, Yunus Bas wrote:
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de
Changes in v3:
- No changes in general, added additional maintainers and also
sending to general kernel mailing list
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 21939d4352cf..07433bff6c2b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2008,6 +2008,32 @@ static const struct panel_desc edt_et057090dhu = { .connector_type = DRM_MODE_CONNECTOR_DPI, }; +static const struct drm_display_mode edt_etmv570g2dhu_mode = { + .clock = 25175, + .hdisplay = 640, + .hsync_start = 640, + .hsync_end = 640 + 16, + .htotal = 640 + 16 + 30 + 114, + .vdisplay = 480, + .vsync_start = 480 + 10, + .vsync_end = 480 + 10 + 3, + .vtotal = 480 + 10 + 3 + 35, + .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC, +};
+static const struct panel_desc edt_etmv570g2dhu = { + .modes = &edt_etmv570g2dhu_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 115, + .height = 86, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +};
static const struct drm_display_mode edt_etm0700g0dh6_mode = { .clock = 33260, .hdisplay = 800, @@ -4338,6 +4364,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et057090dhu", .data = &edt_et057090dhu, + }, { + .compatible = "edt,etmv570g2dhu", + .data = &edt_etmv570g2dhu, }, { .compatible = "edt,et070080dh6", .data = &edt_etm0700g0dh6,
This list must be alphabetically sorted after compatible.
"edt,etmv570g2dhu" comes after "edt,et070080dh6"
The same order must be used where edt_etmv570g2dhu is defined. Sorry for this nit, but if we fails to follw it we will soon have chaos.
Of course, sorry for not noticing earlier. I will change this.
Regards, Yunus
The rest looks good, everything needed is defined.
Sam