On 5/2/22 18:07, Laurent Pinchart wrote:
Hi Javier,
Thank you for the patch.
On Mon, May 02, 2022 at 05:38:59PM +0200, Javier Martinez Canillas wrote:
By default the bits per pixel for the emulated framebuffer device is set to dev->mode_config.preferred_depth, but some devices need another value.
Since this second parameter is only used by a few drivers, and to allow drivers to use it for passing other configurations when registering the fbdev, rename @preferred_bpp to @options and make it a multi-field param.
The DRM_FB_OPTION() and DRM_FB_GET_OPTION() macros are provided to drivers for computing options bitfield values and getting the values respectively
For now, only the DRM_FB_BPP option exists but other options can be added.
Suggested-by: Thomas Zimmermann tzimmermann@suse.de Signed-off-by: Javier Martinez Canillas javierm@redhat.com Reviewed-by: Thomas Zimmermann tzimmermann@suse.de Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Changes in v2:
- Rename DRM_FB_SET_OPTION() to DRM_FB_SET() and make more clear in the
I assume you meant DRM_FB_OPTION() here, not DRM_FB_SET().
kernel-doc what this macro does (Laurent Pinchart).
Right, that's a typo. The patch description and content are correct though.
I'll fix the patch history log in v3.