Re: [PATCH libdrm] intel: use drm namespace for exported functions

On 6 September 2018 at 14:52, Eric Engestrom eric.engestrom@intel.com wrote:

And add them to the list of exported function to fix the tests.

Fixes: 4e81d4f9c9b7fd6510cf "intel: add generic functions to check PCI ID" Cc: Lucas De Marchi lucas.demarchi@intel.com Cc: Rodrigo Vivi rodrigo.vivi@intel.com Signed-off-by: Eric Engestrom eric.engestrom@intel.com

---

Lucas, I'm assuming you meant to export those functions (and macros, like `IS_GEN11()`), right? If so, you need to namespace them, and add them to the list of allowed exports.

The function isn't one part of the public API. So I'd keep the name and add the drm_private notation (adds visibility=hidden)

-Emil