Re: [PATCH] drm: take global drm mutex around sysfs files

On Thu, Feb 9, 2012 at 21:24, Eugeni Dodonov eugeni@dodonov.net wrote:

On Thu, Feb 9, 2012 at 15:56, Jesse Barnes jbarnes@virtuousgeek.org wrote:

...

This prevents a race between module init and sysfs access (usually only seen at module reload time, or if somehow your userspace starts fast enough and pokes at /sys/class/drm while the drivers are still initializing).

Signed-off-by: Jesse Barnes jbarnes@virtuousgeek.org

Reviewed-by: Eugeni Dodonov eugeni.dodonov@intel.com

drm_global_mutex is our own little bkl and we won't ever be fixing this disaster by spreading the disease. So lacking better reasons for this patch:

Nacked-by: Daniel Vetter daniel.vetter@ffwll.ch

Yes, I know that setup/teardown in drm core is a full-blown middlelayer screwup ...