On Wed, Sep 17, 2014 at 1:44 AM, Joonyoung Shim jy0922.shim@samsung.com wrote:
It's problem to add this from commit 25c8b5c3048cb6c98d402ca8d4735ccf910f727c.
My patch moves that drm_framebuffer_reference() call to the plane function which is called from crtc_mode_set context (and also called in crtc pageflip path), so there should be no problem here.
Chip specific drm driver internally doesn't have to care fb reference count if there is no special case. We should have switched to universal plane at that time.
To me it seems like the chip-specific DRM drivers do need to add a reference in the crtc_mode_set and crtc page flip paths otherwise framebuffer removal crashes (expecting to remove 3 references), as noted by my testing and also in commit 25c8b5c304.
However, I'll be happy if universal planes means the driver does not have to care about this any more. Andrej, please go ahead if you are interested, I'll be happy to test your results.
Thanks Daniel