RE: [Intel-gfx] [PATCH v3 07/17] drm: Add logging function for DP VSC SDP

-----Original Message----- From: Intel-gfx intel-gfx-bounces@lists.freedesktop.org On Behalf Of Gwan- gyeong Mun Sent: Tuesday, February 4, 2020 4:50 AM To: intel-gfx@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org; dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH v3 07/17] drm: Add logging function for DP VSC SDP

When receiving video it is very useful to be able to log DP VSC SDP. This greatly simplifies debugging.

v2: Minor style fix v3: Move logging functions to drm core [Jani N]

Looks good to me. Reviewed-by: Uma Shankar uma.shankar@intel.com

Signed-off-by: Gwan-gyeong Mun gwan-gyeong.mun@intel.com

drivers/gpu/drm/drm_dp_helper.c | 174 ++++++++++++++++++++++++++++++++ include/drm/drm_dp_helper.h | 3 + 2 files changed, 177 insertions(+)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c index 5a103e9b3c86..5e3aef8c32e0 100644 --- a/drivers/gpu/drm/drm_dp_helper.c +++ b/drivers/gpu/drm/drm_dp_helper.c @@ -1395,3 +1395,177 @@ int drm_dp_dsc_sink_supported_input_bpcs(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_S return num_bpc; } EXPORT_SYMBOL(drm_dp_dsc_sink_supported_input_bpcs);

+static const char *dp_colorspace_get_name(enum dp_colorspace +colorspace) {

• if (colorspace < 0 || colorspace > DP_COLORSPACE_RESERVED)

• return "Invalid";
  

• switch (colorspace) {
• case DP_COLORSPACE_RGB:

• return "RGB";
  

• case DP_COLORSPACE_YUV444:

• return "YUV444";
  

• case DP_COLORSPACE_YUV422:

• return "YUV422";
  

• case DP_COLORSPACE_YUV420:

• return "YUV420";
  

• case DP_COLORSPACE_Y_ONLY:

• return "Y_ONLY";
  

• case DP_COLORSPACE_RAW:

• return "RAW";
  

• default:

• return "Reserved";
  

• }

+}

+static const char *dp_colorimetry_get_name(enum dp_colorspace colorspace,

• 			   enum dp_colorimetry colorimetry) {
  

• if (colorspace < 0 || colorspace > DP_COLORSPACE_RESERVED)

• return "Invalid";
  

• switch (colorimetry) {
• case DP_COLORIMETRY_DEFAULT:

• switch (colorspace) {
  

• case DP_COLORSPACE_RGB:
  

• 	return "sRGB";
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "BT.601";
  

• case DP_COLORSPACE_Y_ONLY:
  

• 	return "DICOM PS3.14";
  

• case DP_COLORSPACE_RAW:
  

• 	return "Custom Color Profile";
  

• default:
  

• 	return "Reserved";
  

• }
  

• case DP_COLORIMETRY_RGB_WIDE_FIXED: /* and

DP_COLORIMETRY_BT709_YCC */

• switch (colorspace) {
  

• case DP_COLORSPACE_RGB:
  

• 	return "Wide Fixed";
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "BT.709";
  

• default:
  

• 	return "Reserved";
  

• }
  

• case DP_COLORIMETRY_RGB_WIDE_FLOAT: /* and

DP_COLORIMETRY_XVYCC_601 */

• switch (colorspace) {
  

• case DP_COLORSPACE_RGB:
  

• 	return "Wide Float";
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "xvYCC 601";
  

• default:
  

• 	return "Reserved";
  

• }
  

• case DP_COLORIMETRY_OPRGB: /* and DP_COLORIMETRY_XVYCC_709 */

• switch (colorspace) {
  

• case DP_COLORSPACE_RGB:
  

• 	return "OpRGB";
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "xvYCC 709";
  

• default:
  

• 	return "Reserved";
  

• }
  

• case DP_COLORIMETRY_DCI_P3_RGB: /* and DP_COLORIMETRY_SYCC_601

*/

• switch (colorspace) {
  

• case DP_COLORSPACE_RGB:
  

• 	return "DCI-P3";
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "sYCC 601";
  

• default:
  

• 	return "Reserved";
  

• }
  

• case DP_COLORIMETRY_RGB_CUSTOM: /* and

DP_COLORIMETRY_OPYCC_601 */

• switch (colorspace) {
  

• case DP_COLORSPACE_RGB:
  

• 	return "Custom Profile";
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "OpYCC 601";
  

• default:
  

• 	return "Reserved";
  

• }
  

• case DP_COLORIMETRY_BT2020_RGB: /* and

DP_COLORIMETRY_BT2020_CYCC */

• switch (colorspace) {
  

• case DP_COLORSPACE_RGB:
  

• 	return "BT.2020 RGB";
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "BT.2020 CYCC";
  

• default:
  

• 	return "Reserved";
  

• }
  

• case DP_COLORIMETRY_BT2020_YCC:

• switch (colorspace) {
  

• case DP_COLORSPACE_YUV444:
  

• case DP_COLORSPACE_YUV422:
  

• case DP_COLORSPACE_YUV420:
  

• 	return "BT.2020 YCC";
  

• default:
  

• 	return "Reserved";
  

• }
  

• default:

• return "Invalid";
  

• }

+}

+static const char *dp_dynamic_range_get_name(enum dp_dynamic_range +dynamic_range) {

• switch (dynamic_range) {
• case DP_DYNAMIC_RANGE_VESA:

• return "VESA range";
  

• case DP_DYNAMIC_RANGE_CTA:

• return "CTA range";
  

• default:

• return "Invalid";
  

• }

+}

+static const char *dp_content_type_get_name(enum dp_content_type +content_type) {

• switch (content_type) {
• case DP_CONTENT_TYPE_NOT_DEFINED:

• return "Not defined";
  

• case DP_CONTENT_TYPE_GRAPHICS:

• return "Graphics";
  

• case DP_CONTENT_TYPE_PHOTO:

• return "Photo";
  

• case DP_CONTENT_TYPE_VIDEO:

• return "Video";
  

• case DP_CONTENT_TYPE_GAME:

• return "Game";
  

• default:

• return "Reserved";
  

• }

+}

+void drm_dp_vsc_sdp_log(const char *level, struct device *dev,

• 	const struct drm_dp_vsc_sdp *vsc)
  

+{ +#define DP_SDP_LOG(fmt, ...) dev_printk(level, dev, fmt, ##__VA_ARGS__)

• DP_SDP_LOG("DP SDP: %s, revision %u, length %u\n", "VSC",

•    vsc->revision, vsc->length);
  

• DP_SDP_LOG(" colorspace: %s\n",

•    dp_colorspace_get_name(vsc->colorspace));
  

• DP_SDP_LOG(" colorimetry: %s\n",

•    dp_colorimetry_get_name(vsc->colorspace, vsc->colorimetry));
  

• DP_SDP_LOG(" bpc: %u\n", vsc->bpc);
• DP_SDP_LOG(" dynamic range: %s\n",

•    dp_dynamic_range_get_name(vsc->dynamic_range));
  

• DP_SDP_LOG(" content type: %s\n",

•    dp_content_type_get_name(vsc->content_type));
  

+#undef DP_SDP_LOG +} +EXPORT_SYMBOL(drm_dp_vsc_sdp_log); diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index c098727681fa..00b775df6241 100644 --- a/include/drm/drm_dp_helper.h +++ b/include/drm/drm_dp_helper.h @@ -1266,6 +1266,9 @@ struct drm_dp_vsc_sdp { enum dp_content_type content_type; };

+void drm_dp_vsc_sdp_log(const char *level, struct device *dev,

• 	const struct drm_dp_vsc_sdp *vsc);
  

int drm_dp_psr_setup_time(const u8 psr_cap[EDP_PSR_RECEIVER_CAP_SIZE]);

static inline int

2.24.1

---

Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx