On Mon, Mar 19, 2018 at 10:35:30AM +0530, Arushi Singhal wrote:
This patch replace list_entry with list_{next/prev}_entry as it makes the code more clear to read. Done using coccinelle:
@@ expression e1; identifier e3; type t; @@ (
- list_entry(e1->e3.next,t,e3)
- list_next_entry(e1,e3)
|
- list_entry(e1->e3.prev,t,e3)
- list_prev_entry(e1,e3)
)
Signed-off-by: Arushi Singhal arushisinghal19971997@gmail.com
Thanks for your patch. Looks correct, but for merge technical reasons can you please split it into 2 patches? One for drm_lease.c, with a drm/lease: prefix, and one for the nouveau driver change, with a nouveau: prefix. Both patches need to be submitted to slightly different sets of maintainers too, pls consult scripts/get_maintainers.pl
Thanks, Daniel
drivers/gpu/drm/drm_lease.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c index 1402c0e..4dcfb5f 100644 --- a/drivers/gpu/drm/drm_lease.c +++ b/drivers/gpu/drm/drm_lease.c @@ -340,7 +340,7 @@ static void _drm_lease_revoke(struct drm_master *top) break;
/* Over */
master = list_entry(master->lessee_list.next, struct drm_master, lessee_list);
master = list_next_entry(master, lessee_list);} diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c index e4c8d31..81c3567 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/clk/base.c @@ -134,7 +134,7 @@ nvkm_cstate_find_best(struct nvkm_clk *clk, struct nvkm_pstate *pstate, nvkm_volt_map(volt, volt->max2_id, clk->temp));
for (cstate = start; &cstate->head != &pstate->list;
cstate = list_entry(cstate->head.prev, typeof(*cstate), head)) {
cstate = list_prev_entry(cstate, head)) {-- 2.7.4
-- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. To post to this group, send email to outreachy-kernel@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180319050530.GA25589%40.... For more options, visit https://groups.google.com/d/optout.