Re: [PATCH] drm/rockchip: vop2: unlock on error path in vop2_crtc_atomic_enable()

On Mon, May 09, 2022 at 12:05:05PM +0300, Dan Carpenter wrote:

This error path needs an unlock before returning.

Indeed.

Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com

Acked-by: Sascha Hauer s.hauer@pengutronix.de

Sascha

---

drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 0b49fed16535..b68922943825 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1524,6 +1524,7 @@ static void vop2_crtc_atomic_enable(struct drm_crtc *crtc, if (ret < 0) { drm_err(vop2->drm, "failed to enable dclk for video port%d - %d\n", vp->id, ret);

• vop2_unlock(vop2);
  

  return; }

-- 2.35.1