This patch adds a simple driver to handle all the LCD and LED powerup/down routines needed to support eDP/eDP-LVDS panels supported on exynos boards.
The LCD and LED units are usually powered up via regulators, and almost on all boards, we will have a BL_EN pin to enable/ disable the backlight. Sometimes, we can have LCD_EN switches as well. The routines in this driver can be used to control panel power sequence on such boards.
Signed-off-by: Ajay Kumar ajaykumar.rs@samsung.com --- Changes since V1: Added routine for post_disable, removed few unwanted headers. Refactored a lot of code.
.../devicetree/bindings/panel/exynos-dp-panel.txt | 45 ++++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-exynos-dp.c | 251 ++++++++++++++++++++ 4 files changed, 306 insertions(+) create mode 100644 Documentation/devicetree/bindings/panel/exynos-dp-panel.txt create mode 100644 drivers/gpu/drm/panel/panel-exynos-dp.c
diff --git a/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt b/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt new file mode 100644 index 0000000..3fbca54 --- /dev/null +++ b/Documentation/devicetree/bindings/panel/exynos-dp-panel.txt @@ -0,0 +1,45 @@ +exynos_DP_panel/DP_to_LVDS_panel + +Required properties: + - compatible: "samsung,exynos-dp-panel" + +Optional properties: + -samsung,lcd-en-gpio: + eDP panel LCD poweron GPIO. + Indicates which GPIO needs to be powered up as output + to powerup/enable the switch to the LCD panel. + -samsung,led-en-gpio: + eDP panel LED enable GPIO. + Indicates which GPIO needs to be powered up as output + to enable the backlight. + -samsung,panel-pre-enable-delay: + delay value in ms required for panel_pre_enable process + Delay in ms needed for the eDP panel LCD unit to + powerup, and delay needed between panel_VCC and + video_enable. + -samsung,panel-enable-delay: + delay value in ms required for panel_enable process + Delay in ms needed for the eDP panel backlight/LED unit + to powerup, and delay needed between video_enable and + BL_EN. + samsung,panel-disable-delay: + delay value in ms required for panel_disable process + Delay in ms needed for the eDP panel backlight/LED unit + powerdown, and delay needed between BL_DISABLE and + video_disable. + samsung,panel-post-disable-delay: + delay value in ms required for panel_post_disable process + Delay in ms needed for the eDP panel LCD unit to + to powerdown, and delay between video_disable and + panel_VCC going down. + +Example: + + dp-panel { + compatible = "samsung,exynos-dp-panel"; + samsung,led-en-gpio = <&gpx3 0 1>; + samsung,panel-pre-enable-delay = <40>; + samsung,panel-enable-delay = <20>; + samsung,panel-disable-delay = <20>; + samsung,panel-post-disable-delay = <30>; + }; diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 4ec874d..ea9d5ac 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -30,4 +30,13 @@ config DRM_PANEL_S6E8AA0 select DRM_MIPI_DSI select VIDEOMODE_HELPERS
+config DRM_PANEL_EXYNOS_DP + tristate "support for DP panels" + depends on OF && DRM_PANEL && DRM_EXYNOS_DP + help + DRM panel driver for DP panels and LVDS connected via DP bridges + that need at most a regulator for LCD unit, a regulator for LED unit + and/or enable GPIOs for LCD or LED units. Delay values can also be + specified to support powerup and powerdown process. + endmenu diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 8b92921..30311a4 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o obj-$(CONFIG_DRM_PANEL_LD9040) += panel-ld9040.o obj-$(CONFIG_DRM_PANEL_S6E8AA0) += panel-s6e8aa0.o +obj-$(CONFIG_DRM_PANEL_EXYNOS_DP) += panel-exynos-dp.o diff --git a/drivers/gpu/drm/panel/panel-exynos-dp.c b/drivers/gpu/drm/panel/panel-exynos-dp.c new file mode 100644 index 0000000..5568d6a --- /dev/null +++ b/drivers/gpu/drm/panel/panel-exynos-dp.c @@ -0,0 +1,251 @@ +/* + * Exynos DP panel driver + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd + * + * Ajay Kumar ajaykumar.rs@samsung.com + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include <linux/gpio.h> +#include <linux/module.h> +#include <linux/of_gpio.h> +#include <linux/of_platform.h> +#include <linux/platform_device.h> +#include <linux/regulator/consumer.h> + +#include <drm/drmP.h> +#include <drm/drm_crtc.h> +#include <drm/drm_panel.h> + +enum panel_state { + PRE_ENABLE, + ENABLE, + DISABLE, + POST_DISABLE, +}; + +struct panel_exynos_dp { + struct drm_panel base; + struct regulator *backlight_fet; + struct regulator *lcd_fet; + int led_en_gpio; + int lcd_en_gpio; + int panel_pre_enable_delay; + int panel_enable_delay; + int panel_disable_delay; + int panel_post_disable_delay; + enum panel_state panel_state; +}; + +static inline struct panel_exynos_dp *to_panel(struct drm_panel *panel) +{ + return container_of(panel, struct panel_exynos_dp, base); +} + +static int panel_exynos_dp_post_disable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != DISABLE) { + dev_err(dev, "invoking panel_exynos_dp_post_disable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) + gpio_set_value(dp_panel->lcd_en_gpio, 0); + + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) + regulator_disable(dp_panel->lcd_fet); + + msleep(dp_panel->panel_post_disable_delay); + + dp_panel->panel_state = POST_DISABLE; + + return 0; +} + +static int panel_exynos_dp_disable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != ENABLE) { + dev_err(dev, "invoking panel_exynos_dp_disable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (gpio_is_valid(dp_panel->led_en_gpio)) + gpio_set_value(dp_panel->led_en_gpio, 0); + + if (!IS_ERR_OR_NULL(dp_panel->backlight_fet)) + regulator_disable(dp_panel->backlight_fet); + + msleep(dp_panel->panel_disable_delay); + + dp_panel->panel_state = DISABLE; + + return 0; +} + +static int panel_exynos_dp_pre_enable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != POST_DISABLE) { + dev_err(dev, "invoking panel_exynos_dp_pre_enable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (!IS_ERR_OR_NULL(dp_panel->lcd_fet)) + if (regulator_enable(dp_panel->lcd_fet)) + DRM_ERROR("Failed to enable LCD fet\n"); + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) + gpio_set_value(dp_panel->lcd_en_gpio, 1); + + msleep(dp_panel->panel_pre_enable_delay); + + dp_panel->panel_state = PRE_ENABLE; + + return 0; +} + +static int panel_exynos_dp_enable(struct drm_panel *panel) +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + struct device *dev = dp_panel->base.dev; + + if (dp_panel->panel_state != PRE_ENABLE) { + dev_err(dev, "invoking panel_exynos_dp_enable" \ + "from an improper state\n"); + return -EINVAL; + } + + if (!IS_ERR_OR_NULL(dp_panel->backlight_fet)) + if (regulator_enable(dp_panel->backlight_fet)) + DRM_ERROR("Failed to enable LED fet\n"); + + msleep(dp_panel->panel_enable_delay); + + if (gpio_is_valid(dp_panel->led_en_gpio)) + gpio_set_value(dp_panel->led_en_gpio, 1); + + dp_panel->panel_state = ENABLE; + + return 0; +} + +static const struct drm_panel_funcs panel_exynos_dp_funcs = { + .post_disable = panel_exynos_dp_post_disable, + .disable = panel_exynos_dp_disable, + .pre_enable = panel_exynos_dp_pre_enable, + .enable = panel_exynos_dp_enable, +}; + +static int panel_exynos_dp_probe(struct platform_device *pdev) +{ + struct panel_exynos_dp *dp_panel; + struct device *dev = &pdev->dev; + int ret; + + dp_panel = devm_kzalloc(dev, sizeof(*dp_panel), GFP_KERNEL); + if (!dp_panel) + return -ENOMEM; + + dp_panel->panel_state = POST_DISABLE; + + dp_panel->lcd_en_gpio = of_get_named_gpio(dev->of_node, + "samsung,lcd-en-gpio", 0); + dp_panel->led_en_gpio = of_get_named_gpio(dev->of_node, + "samsung,led-en-gpio", 0); + + of_property_read_u32(dev->of_node, "samsung,panel-pre-enable-delay", + &dp_panel->panel_pre_enable_delay); + of_property_read_u32(dev->of_node, "samsung,panel-enable-delay", + &dp_panel->panel_enable_delay); + of_property_read_u32(dev->of_node, "samsung,panel-disable-delay", + &dp_panel->panel_disable_delay); + of_property_read_u32(dev->of_node, "samsung,panel-post-disable-delay", + &dp_panel->panel_post_disable_delay); + + dp_panel->lcd_fet = devm_regulator_get(dev, "lcd_vdd"); + if (IS_ERR(dp_panel->lcd_fet)) + return PTR_ERR(dp_panel->lcd_fet); + + dp_panel->backlight_fet = devm_regulator_get(dev, "vcd_led"); + if (IS_ERR(dp_panel->backlight_fet)) + return PTR_ERR(dp_panel->backlight_fet); + + if (gpio_is_valid(dp_panel->lcd_en_gpio)) { + ret = devm_gpio_request_one(dev, dp_panel->lcd_en_gpio, + GPIOF_OUT_INIT_LOW, "lcd_en_gpio"); + if (ret) { + DRM_ERROR("failed to get lcd-en gpio [%d]\n", ret); + return ret; + } + } else { + dp_panel->lcd_en_gpio = -ENODEV; + } + + if (gpio_is_valid(dp_panel->led_en_gpio)) { + ret = devm_gpio_request_one(dev, dp_panel->led_en_gpio, + GPIOF_OUT_INIT_LOW, "led_en_gpio"); + if (ret) { + DRM_ERROR("failed to get led-en gpio [%d]\n", ret); + return ret; + } + } else { + dp_panel->led_en_gpio = -ENODEV; + } + + dp_panel->panel_state = POST_DISABLE; + drm_panel_init(&dp_panel->base); + dp_panel->base.dev = dev; + dp_panel->base.funcs = &panel_exynos_dp_funcs; + + ret = drm_panel_add(&dp_panel->base); + if (ret < 0) + return ret; + + dev_set_drvdata(dev, dp_panel); + + return 0; +} + +static int panel_exynos_dp_remove(struct platform_device *pdev) +{ + struct panel_exynos_dp *dp_panel = dev_get_drvdata(&pdev->dev); + + dp_panel->panel_state = ENABLE; + panel_exynos_dp_disable(&dp_panel->base); + panel_exynos_dp_post_disable(&dp_panel->base); + + drm_panel_detach(&dp_panel->base); + drm_panel_remove(&dp_panel->base); + + return 0; +} + +static const struct of_device_id exynos_dp_panel_dt_match[] = { + { .compatible = "samsung,exynos-dp-panel" }, + {}, +}; + +struct platform_driver exynos_dp_panel_driver = { + .driver = { + .name = "exynos-dp-panel", + .owner = THIS_MODULE, + .of_match_table = exynos_dp_panel_dt_match, + }, + .probe = panel_exynos_dp_probe, + .remove = panel_exynos_dp_remove, +};