Re: [PATCH RFC 01/19] drm: Stop including drm_bridge.h from drm_crtc.h

Hi Boris.

Good to see that you kept the alphabetical order in the include files. One nit below. With this fixed: Reviewed-by: Sam Ravnborg sam@ravnborg.org

Sam

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.h b/drivers/gpu/drm/msm/hdmi/hdmi.h index 982865866a29..c681a9e22484 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.h +++ b/drivers/gpu/drm/msm/hdmi/hdmi.h @@ -7,6 +7,8 @@ #ifndef __HDMI_CONNECTOR_H__ #define __HDMI_CONNECTOR_H__

+#include <drm/drm_bridge.h>

#include <linux/i2c.h> #include <linux/clk.h> #include <linux/platform_device.h>

Please follow the same order of include blocks as we see in other files:

#include <linux/*.h>

#include <drm/*.h>

#include "*.h"

And with an empty line between the blocks, and sorted withint the blocks.