Re: [PATCH 1/9] drm/i915/intel_i2c: cleanup

On Wed, 7 Mar 2012 19:50:42 +0800, Daniel Kurtz djkurtz@chromium.org wrote:

80 col, spaces around operators and other basic cleanup.

Signed-off-by: Daniel Kurtz djkurtz@chromium.org

drivers/gpu/drm/i915/intel_i2c.c | 24 ++++++++++++++++-------- 1 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c index d30cccc..a94e383 100644 --- a/drivers/gpu/drm/i915/intel_i2c.c +++ b/drivers/gpu/drm/i915/intel_i2c.c @@ -236,8 +236,9 @@ gmbus_xfer(struct i2c_adapter *adapter, int i, reg_offset;

if (bus->force_bit)

• return intel_i2c_quirk_xfer(dev_priv,
  

• 			    bus->force_bit, msgs, num);
  

• return intel_i2c_quirk_xfer(dev_priv, bus->force_bit, msgs,
  

• 			    num);
  

NAK just on that around. The new line was put there for a reason as there is a distinction in the types of parameters, it visually grouped the control arguments from the object. -Chris